dolphin-emu-primehack: fix name in desktop file

[romatthe]

Description of changes

Both the regular dolphin-emu and the dolphin-emu-primehack packages install desktop files for their respective application that carry the name "Dolphin Emulator" when shown in a desktop environment. This PR changes the name of dolphin-emu-primehack to PrimeHack in the desktop file.

It may be a little contentious to rename this, since PrimeHack is essentially a Dolphin fork with some changes, so here's my reasoning:

1. Shiiion's fork of Dolphin is listed as shiiion/dolphin on Github, but the readme clearly calls the project "PrimeHack".
2. The binaries carry two different names in nixpkgs (dolphin-emu and dolphin-emu-primehack), so why name the applications the same in desktop environments?
3. Searching for "PrimeHack" doesn't show anything, but searching for "Dolphin" shows both.
4. I have both packages installed by default, and this causes them to appear side-by-side with the same name, which is just not helpful:

In light of this, I think my proposed change makes a lot of sense.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[SuperSamus]

Small note, all of these substitutions will need to be removed once (and if) shiiion/dolphin#118 is merged.
Until then, approved.

[romatthe]

Small note, all of these substitutions will need to be removed once (and if) shiiion/dolphin#118 is merged. Until then, approved.

Good catch, didn't see that PR.