BeatSaberModManager: init at 0.0.2 #196648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
Atemu
force-pushed
the
init/BeatSaberModManager
branch
from
614e403 to
6fdd383
Compare
Atemu
commented
Oct 18, 2022
Comment on lines
27
to
30
| dotnetInstallFlags = [ | ||
| # FIXME It doesn't like that for some reason beyond my ability to package dotnet | ||
| "-p:PublishSingleFile=false" | ||
| ]; |
There was a problem hiding this comment.
Specifically, it fails with
Executing dotnetInstallHook
MSBuild version 17.3.1+2badb37d1 for .NET
IPA-lib -> /nix/store/hsx50dc5yly2bqinqcdr9sz6xs9zfawc-BeatSaberModManager-0.0.2/lib/BeatSaberModManager/
/nix/store/a5x48hb982y79kkh39n8wh16b62vi1iz-dotnet-sdk-6.0.401/sdk/6.0.401/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Publish.targets(102,5): error NETSDK1097: It is not supported to publish an application to a single-file without specifying a RuntimeIdentifier. You must either specify a RuntimeIdentifier or set PublishSingleFile to false. [/build/source/BeatSaberModManager/BeatSaberModManager.csproj]
If anyone more knowledgable in dotnet knows how to fix this without disabling single-file, let me know.
There was a problem hiding this comment.
Found a solution but it's not pretty.
There was a problem hiding this comment.
Created an issue affederaffe/BeatSaberModManager#5
|
I'd love to see this merged before branch-off. |
K900
approved these changes
Nov 5, 2022
|
@K900 thanks! You don't need a headset btw; you can observe all of BSMM's effects with just a BeatSaber installation. It's just a fancy GUI to download files and shuffle them around. Speaking of 'BSMM', do you think adding an alias would be good? |
Atemu
added
the
12.approvals: 1
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes