mumps: refactor makeFlags with toString

NixOS · Nov 12, 2024 · 727aa59 · 727aa59
1 parent 928969d
commit 727aa59
Showing 1 changed file with 51 additions and 49 deletions.
diff --git a/pkgs/by-name/mu/mumps/package.nix b/pkgs/by-name/mu/mumps/package.nix
@@ -19,42 +19,6 @@
 }:
 assert withParmetis -> mpiSupport;
 assert withPtScotch -> mpiSupport;
-let
-  profile = if mpiSupport then "debian.PAR" else "debian.SEQ";
-  metisFlags =
-    if withParmetis then
-      ''
-        IMETIS="-I${parmetis}/include -I${metis}/include" \
-        LMETIS="-L${parmetis}/lib -lparmetis -L${metis}/lib -lmetis"
-      ''
-    else
-      ''
-        IMETIS=-I${metis}/include \
-        LMETIS="-L${metis}/lib -lmetis"
-      '';
-  scotchFlags =
-    if withPtScotch then
-      ''
-        ISCOTCH=-I${scotch.dev}/include \
-        LSCOTCH="-L${scotch}/lib -lptscotch -lptesmumps -lptscotcherr"
-      ''
-    else
-      ''
-        ISCOTCH=-I${scotch.dev}/include \
-        LSCOTCH="-L${scotch}/lib -lesmumps -lscotch -lscotcherr"
-      '';
-  macroFlags =
-    "-Dmetis -Dpord -Dscotch"
-    + lib.optionalString withParmetis " -Dparmetis"
-    + lib.optionalString withPtScotch " -Dptscotch";
-  # Optimized options
-  # Disable -fopenmp in lines below to benefit from OpenMP
-  optFlags = ''
-    OPTF="-O3 -fallow-argument-mismatch" \
-    OPTL="-O3" \
-    OPTC="-O3"
-  '';
-in
 stdenv.mkDerivation (finalAttrs: {
   name = "mumps";
   version = "5.7.3";
@@ -70,25 +34,63 @@ stdenv.mkDerivation (finalAttrs: {
       "-Wl,-install_name,$out/lib/libmumps_common"
   '';
 
-  configurePhase = ''
-    cp Make.inc/Makefile.${profile} ./Makefile.inc
-  '';
+  configurePhase =
+    let
+      profile = if mpiSupport then "debian.PAR" else "debian.SEQ";
+    in
+    ''
+      cp Make.inc/Makefile.${profile} ./Makefile.inc
+    '';
 
   enableParallelBuilding = true;
 
+  LMETIS = toString ([ "-lmetis" ] ++ lib.optional withParmetis "-lparmetis");
+  LSCOTCH = toString (
+    if withPtScotch then
+      [
+        "-lptscotch"
+        "-lptesmumps"
+        "-lptscotcherr"
+      ]
+    else
+      [
+        "-lesmumps"
+        "-lscotch"
+        "-lscotcherr"
+      ]
+  );
+  ORDERINGSF = toString (
+    [
+      "-Dmetis"
+      "-Dpord"
+      "-Dscotch"
+    ]
+    ++ lib.optional withParmetis "-Dparmetis"
+    ++ lib.optional withPtScotch "-Dptscotch"
+  );
+  OPTF = toString [
+    "-O3"
+    "-fallow-argument-mismatch"
+  ];
+
   preBuild = ''
-    makeFlagsArray+=(${metisFlags} ${scotchFlags} ORDERINGSF="${macroFlags}" ${optFlags})
+    makeFlagsArray+=(
+      ISCOTCH=-I${scotch.dev}/include
+      LSCOTCH="$LSCOTCH"
+      LMETIS="$LMETIS"
+      ORDERINGSF="$ORDERINGSF"
+      OPTF="$OPTF"
+      OPTC=-O3
+      OPTL=-O3
+      SCALAP=-lscalapack
+      allshared
+    )
   '';
 
-  makeFlags =
-    lib.optionals stdenv.hostPlatform.isDarwin [
-      "SONAME="
-      "LIBEXT_SHARED=.dylib"
-    ]
-    ++ [
-      "SCALAP=-lscalapack"
-      "allshared"
-    ];
+  makeFlags = lib.optionals stdenv.hostPlatform.isDarwin [
+    "SONAME="
+    "LIBEXT_SHARED=.dylib"
+  ];
 
   installPhase =
     ''