lenovo/thinkpad/t480s: Automatically downgrade kernel to 6.10 #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Dec 1, 2024
| # There is currently a kernel regression with the psmouse driver. As such, the kernel version is held back to 6.10. | ||
| # See https://bugzilla.kernel.org/show_bug.cgi?id=219352 | ||
| boot.kernelPackages = lib.mkIf (lib.versionAtLeast config.boot.kernelPackages "6.11") ( | ||
| lib.warn "Linux kernel held back to 6.10 due to regression: https://bugzilla.kernel.org/show_bug.cgi?id=219352" pkgs.linuxPackages_6_10 |
There was a problem hiding this comment.
Should we not just warn in this case? The 6.10 kernel might get removed at this point.
There was a problem hiding this comment.
The default kernel right now is 6.6 iirc, so I doubt that's gonna happen.
There was a problem hiding this comment.
The kernel package referenced here is 6.10. It's not an lts kernel. But the actual issue of this code is that it's an infinite recursion. You are checking config.boot.kernelPackage while writing to the same option.
There was a problem hiding this comment.
Yea, this hasn't been tested. TBH I completely forgot about this PR; I somehow forgot to put it on my tracking board after opening it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
See https://bugzilla.kernel.org/show_bug.cgi?id=219352
Things done
nixos-hardwareandimporting it via
<nixos-hardware>or Flake input