Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated map2string to be generic #54

Merged
merged 1 commit into from
Jan 16, 2025
Merged

updated map2string to be generic #54

merged 1 commit into from
Jan 16, 2025

Conversation

kevin-kho
Copy link
Contributor

@kevin-kho kevin-kho commented Jan 16, 2025 •
edited
Loading

  • Removed mapOfAny2string
  • Updated map2string to be generic. It accepts map[string]string or map[string]any
  • %v will work for either map. Using %v for a string will default to %s

pkedy
pkedy approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@pkedy pkedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good use of generics.

@dmitsh dmitsh merged commit 4aa1e2b into NVIDIA:main Jan 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkedy pkedy pkedy approved these changes

@dmitsh dmitsh Awaiting requested review from dmitsh dmitsh is a code owner

@sanjaychatterjee sanjaychatterjee Awaiting requested review from sanjaychatterjee sanjaychatterjee is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevin-kho @pkedy @dmitsh