Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Optimize and clean optimize cuda::std::rotl and cuda::std::rotr #3228

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

fbusato
Copy link
Contributor

@fbusato fbusato commented Jan 1, 2025

Fixes #2239

Description

Use funnel shift intrinsic to optimize cuda::std::rotl and cuda::std::rotr

Require >= C++14

@fbusato fbusato requested review from a team as code owners January 1, 2025 00:24
@fbusato fbusato requested review from miscco and gonidelis January 1, 2025 00:24
@fbusato fbusato changed the title Optimize and clean optimize cuda::std::rotl and cuda::std::rotr [DO NOT MERGE] Optimize and clean optimize cuda::std::rotl and cuda::std::rotr Jan 1, 2025
Copy link
Collaborator

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot break existing users even if we deprecated C++11, so changing that requirement is unfortunately a no go

@fbusato fbusato self-assigned this Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

[FEA]: Provide optimized <bit> functions for device
2 participants