Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of parameter +model.dist_ckpt_load_strictness=log_all in L2_Megatron_Core_T5_Eval #12171

Open
wants to merge 1 commit into
base: ko3n1g/build/bump-pyt-25.01
Choose a base branch
from

Conversation

chtruong814
Copy link
Collaborator

What does this PR do ?

We seemed to use the wrong test parameter for one of the megatron t5 eval tests.

Collection: [Note which collection this PR will affect]

Changelog

  • Fix usage of parameter +model.dist_ckpt_load_strictness=log_all in L2_Megatron_Core_T5_Eval

Usage

n/a

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Copy link
Collaborator

@thomasdhc thomasdhc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants