Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TTS code to remove calls to deprecated functions #12153

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Update TTS code to remove calls to deprecated functions #12153

wants to merge 6 commits into from
+7 −10

Conversation

blisc
Copy link
Collaborator

@blisc blisc commented Feb 12, 2025 •
edited
Loading

What does this PR do ?

Fixes 25.02 bugs

Collection: tts

Changelog

  • Removes calls in tts collection to deprecated tostring_rgb; updates call to random.sample as it no longer supports dicts

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

@github-actions github-actions bot added the TTS label Feb 12, 2025
@blisc blisc added the Run CICD label Feb 12, 2025
@ko3n1g ko3n1g enabled auto-merge (squash) February 12, 2025 20:27
ko3n1g
ko3n1g previously requested changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@ko3n1g ko3n1g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blisc: There are some really minor flake8 issues. Could you address these?

@ko3n1g
Copy link
Collaborator

ko3n1g commented Feb 12, 2025

⚠️ We have entered code-freeze. If this PR should be part of the 25.02 framework-release, please attach the label r2.2.0 before merging this PR. ⚠️

@github-actions GitHub Actions
Copy link
Contributor

[🤖]: Hi @blisc 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@blisc blisc changed the title Fix some bugs Update TTS code to remove calls to deprecated functions Feb 13, 2025
@blisc blisc requested a review from ko3n1g February 13, 2025 15:34
@blisc blisc dismissed ko3n1g’s stale review February 13, 2025 15:34

He's OOO. Removing stale review

@blisc blisc requested a review from chtruong814 February 13, 2025 15:34
@chtruong814
Copy link
Collaborator

@blisc let me know when ready for another review, and I can take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chtruong814 chtruong814 chtruong814 approved these changes

@ko3n1g ko3n1g Awaiting requested review from ko3n1g

Assignees
No one assigned
Labels
r2.2.0 Run CICD TTS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blisc @ko3n1g @chtruong814