Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate DockerBuilder and DockerLauncherBuilder #3186

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Separate DockerBuilder and DockerLauncherBuilder #3186

wants to merge 5 commits into from
+315 −104

Conversation

yhwen
Copy link
Collaborator

@yhwen yhwen commented Jan 28, 2025

Fixes # .

Description

Separate DockerBuilder and DockerLauncherBuilder. Fix the nvflare poc prepare -d 'nvflare/nvflare' by keeping the DockerBuilder as before.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@yhwen yhwen requested a review from chesterxgchen January 28, 2025 17:42
@yhwen
Copy link
Collaborator Author

yhwen commented Jan 30, 2025

/build

@yhwen yhwen enabled auto-merge (squash) January 30, 2025 16:47
@chesterxgchen
Copy link
Collaborator

/build

1 similar comment
@yhwen
Copy link
Collaborator Author

yhwen commented Feb 3, 2025

/build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chesterxgchen chesterxgchen chesterxgchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhwen @chesterxgchen