Skip to content

Commit

Permalink
Merge pull request #120 from NERDDISCO/next
Browse files Browse the repository at this point in the history
Next
  • Loading branch information
TimPietrusky authored Oct 10, 2019
2 parents a888850 + 2eb6b95 commit 65b66cc
Show file tree
Hide file tree
Showing 58 changed files with 1,161 additions and 202 deletions.
36 changes: 16 additions & 20 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,35 +4,31 @@ If you want to contribute please follow the guide in this file.

<!-- toc -->

- [Pull request](#pull-request)
- [Issues](#issues)
- [Development](#development)
- [Contributing](#contributing)
- [Pull request](#pull-request)
- [Issues](#issues)
- [Development](#development)

<!-- tocstop -->

## Pull request

Ensure that the changes are tested and documented.
DO NOT commit any built versions.
* Create your branch from the [next](https://github.com/NERDDISCO/luminave/tree/next) branch
* Ensure that the changes are tested and documented
* This project uses commitizen and conventional changelog. Please use both to ensure that the changes are listed correctly and the commits can be parsed
* If you don't have it installed, [please follow the guidline](https://github.com/commitizen/cz-cli#conventional-commit-messages-as-a-global-utility) to install both `commitizen` and `cz-conventional-changelog`
* When this is done you can use `git cz` to create commit messages that are valid for this project

This project uses commitizen and conventional changelog. Please use either
to ensure that the changes are listed correctly and the commits can be parsed.

Squash before merging and remove the source branch.

## Issues

Please include the browser and operating system.

A snippet of example code helps a lot, a link to the repo with the issue helps even more.
If the issue can be seen live please provide a link.

Include info about your development environment

* Chrome version
* Please include the browser and operating system if this is a bug
* A snippet of example code helps a lot, a link to the repo with the issue helps even more
* If the issue can be seen live please provide a link
* Include info about your development environment
* Please make sure to describe the feature if its something that you want to have added

## Development

`npm <command>`

* `start`: starts the development server
* Read the [Getting Started](https://github.com/NERDDISCO/luminave/tree/next#getting-started) to setup the project locally
* To start it run `npm start`
5 changes: 4 additions & 1 deletion .releaserc
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@
"@semantic-release/release-notes-generator",
"@semantic-release/changelog",
"@semantic-release/git",
"@semantic-release/github"
"@semantic-release/github",
["@semantic-release/npm", {
"npmPublish": false
}],
],
"verifyConditions": [
"@semantic-release/changelog",
Expand Down
1 change: 1 addition & 0 deletions docs/configs/LuminaveConfig_JSConfBP2019.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion integration/modV/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ console.log('modv-integration', '|', 'WebSocket server on port', port)

// The client connection came from cyberpunk goggles
if (con.path === '/cyberpunk') {
const colors = JSON.stringify(dmxData.colors.slice(0, 3))
const colors = JSON.stringify(dmxData.colors.slice(12 * 3, 12 * 3 + 3))
// console.log('send to cyberpunk', JSON.stringify(colors))
con.sendText(colors)
}
Expand Down
Loading

0 comments on commit 65b66cc

Please sign in to comment.