Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update create_task function #194

Closed
wants to merge 2 commits into from
Closed

Update create_task function #194

wants to merge 2 commits into from

Conversation

EddieKuo723
Copy link
Contributor

Fix #136 and update function name

N4S4
N4S4 reviewed Jan 4, 2025
View reviewed changes
Copy link
Owner

@N4S4 N4S4 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downloadstation, as is now, user has the ability to choose version with + download_st_version, with this modification the option won't be available anymore, while uri name was mentioned in docs can be modified to url

@EddieKuo723 EddieKuo723 closed this Jan 5, 2025
@N4S4
Copy link
Owner

N4S4 commented Jan 5, 2025

Make a new PR with all modification but leave the ability to change downloadstation version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N4S4 N4S4 N4S4 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DownloadStation.create_task cannot handle destinations with whitespace
2 participants
@EddieKuo723 @N4S4