Added a couple more vectormath operations #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incoherent-Code
requested review from
rlandav and
JakeShirley
as code owners
rlandav
requested changes
Nov 20, 2024
|
This last commit should fix all the aforementioned issues |
Incoherent-Code
force-pushed
the
main
branch
from
4bbb934 to
2666584
Compare
rlandav
requested changes
Nov 25, 2024
|
Third times the charm. |
rlandav
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a couple more vector math functions.
multiply([vector], [vector])multiplies 2 vectors together.rotateX([vector], [angle])rotates the vector around the x axis.rotateY([vector], [angle])rotates the vector around the y axis.rotateZ([vector], [angle])rotates the vector around the z axis.I wrote tests and ran beachball already. Let me know if you have any concerns.