Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom deployment annotation option #332

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

C0nsultant
Copy link

@C0nsultant C0nsultant commented Jan 6, 2025

TL;DR Allow the user to set a custom set of annotations for the pi-hole deployment in addition to pod-level annotations.

Description of the change

When editing config maps (especially the whitelist), I would like to avoid having to re-run gravity via UI. The reloader controller does this job perfectly, but requires an annotation at the deployment level, an annotation at the pod level does not work. This PR adds the option to supply an optional arbitrary set of annotations for the deployment.

Benefits

Users can now add custom annotations to the deployment in addition to other resources.

Applicable issues

Checklist

@auto-assign auto-assign bot requested a review from MoJo2600 January 6, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adlist isn't applying lists
2 participants