Add Option to deactivate the CPack directives

[fbordeu]

Hello,

Little change to add an option to the cmake files to only install compiled files. In the current cmake files the VisualStudio runtime files are installed. This make it impossible to build a package unsing the conda-force infrastructure on windows (the packages must ship only compiled libs).

MR of the new recipe for mmg for conda-forge. conda-forge/mmgsuite-feedstock#15

Felipe

[CLAassistant]

All committers have signed the CLA.

[taupalosaurus]

Hello,

why would we want to install VS runtime files as well ? Should it be the opposite by default, and only install them if requested ?

Thanks,

--
Nicolas

[taupalosaurus]

Hi @fbordeu , sorry I let this one drag on.

I'm trying to familiarize myself with all this building process. Could you please clarify the path that is taken when cmake copies the VS files ? Do you not need Cpack when you build your conda package ?

Also, it seems that there is an option to have Cpack ignore certain files https://cmake.org/cmake/help/latest/module/CPack.html#variable:CPACK_SOURCE_IGNORE_FILES

Thanks,

[fbordeu]

In conda packages, conda-build is responsible of the software packaging. son cpack is not needed and must not be activated. This MR add the possibility to disconnect cpack directives (the default behavior is not modified).

[taupalosaurus]

what I do not understand is : the cmake rule install(packages) creates rules in the Makefiles to build the package. Do you call that rule explicitly ? Or else, how does it get called ?

I'm wondering if SET (MMG5_PACKAGE FALSE CACHE BOOL "add CPack directives") wouldn't be better for users.

[fbordeu]

ok, (if my memory is good) during the build no cpack directive are executed. but during "make install", the vs files are installed on the install directory. Here the install directory is a prefix defined by the conda-build system.

To make a correct conda-forge package the recipe must install only the files responsible of, no other files. VS files are added as dependencies so the conda installer can solve the dependency tree and install all the neede dependencies.

[taupalosaurus]

If I understand correctly, you build from sources, you do make install and it somehow calls CPack and installs the CPack package ?

It really makes no sense to me. I'm going to open an issue to track this out of the PR.

[taupalosaurus]

For future reference: the option should probably be deactivated by default. We will investigate further in a separate issue.

[fbordeu]

If I understand correctly, you build from sources, you do make install and it somehow calls CPack and installs the CPack package ?

It really makes no sense to me. I'm going to open an issue to track this out of the PR.

No cpack is used during the conda-build. the steps are:

git clone
cmake ...
make ...
make install ...
conda-build make a package of the installed files.