-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: insufficient funds displays incorrect native token (#29828) #30009
Merged
dbrans
merged 1 commit into
Version-v12.11.0
from
cherry-pick-v12.11-33ffbc59ef15116ddddbbfb8df6f30430fe48b82
Jan 30, 2025
Merged
fix: insufficient funds displays incorrect native token (#29828) #30009
dbrans
merged 1 commit into
Version-v12.11.0
from
cherry-pick-v12.11-33ffbc59ef15116ddddbbfb8df6f30430fe48b82
Jan 30, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR addresses an issue where the "Insufficient funds" alert incorrectly displayed "ETH" as the native token, regardless of the actual network's native token #28867. This was observed when users attempted to initiate a transaction on networks with a different native token, such as Polygon, where "POL" should be displayed instead of "ETH". [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29828?quickstart=1) ## **Related issues** #28867 ## **Manual testing steps** 1. Select Polygon 2. Trigger a dapp tx with an account without funds (you can use these tests https://metamask.github.io/test-dapp/) 3. Click on the Alert 4. See POL as the token name ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** https://www.loom.com/share/8dd8001fc8d44da3b77e52a4877427f8 ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
matteoscurati
changed the title
fix: 🐛 fix insufficient funds displays incorrect native token (#2…
fix: insufficient funds displays incorrect native token (#29828)
Jan 30, 2025
OGPoyraz
approved these changes
Jan 30, 2025
Builds ready [f3d1168]
Page Load Metrics (1812 ± 74 ms)
|
dbrans
deleted the
cherry-pick-v12.11-33ffbc59ef15116ddddbbfb8df6f30430fe48b82
branch
January 30, 2025 16:44
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue where the "Insufficient funds" alert incorrectly displayed "ETH" as the native token, regardless of the actual network's native token
#28867. This was observed when users attempted to initiate a transaction on networks with a different native token, such as Polygon, where "POL" should be displayed instead of "ETH".
Related issues
Fixes: #28867
Manual testing steps
Screenshots/Recordings
Before
After
https://www.loom.com/share/8dd8001fc8d44da3b77e52a4877427f8
Pre-merge author checklist
Standards.
Pre-merge reviewer checklist