Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: insufficient funds displays incorrect native token (#29828) #30009

Conversation

matteoscurati
Copy link
Contributor

@matteoscurati matteoscurati commented Jan 30, 2025

Description

This PR addresses an issue where the "Insufficient funds" alert incorrectly displayed "ETH" as the native token, regardless of the actual network's native token
#28867. This was observed when users attempted to initiate a transaction on networks with a different native token, such as Polygon, where "POL" should be displayed instead of "ETH".

Open in GitHub Codespaces

Related issues

Fixes: #28867

Manual testing steps

  1. Select Polygon
  2. Trigger a dapp tx with an account without funds (you can use these tests https://metamask.github.io/test-dapp/)
  3. Click on the Alert
  4. See POL as the token name

Screenshots/Recordings

Before

After

https://www.loom.com/share/8dd8001fc8d44da3b77e52a4877427f8

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This PR addresses an issue where the "Insufficient funds" alert
incorrectly displayed "ETH" as the native token, regardless of the
actual network's native token
#28867. This was
observed when users attempted to initiate a transaction on networks with
a different native token, such as Polygon, where "POL" should be
displayed instead of "ETH".

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29828?quickstart=1)

## **Related issues**

#28867

## **Manual testing steps**

1. Select Polygon
2. Trigger a dapp tx with an account without funds (you can use these
tests https://metamask.github.io/test-dapp/)
3. Click on the Alert
4. See POL as the token name

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

https://www.loom.com/share/8dd8001fc8d44da3b77e52a4877427f8

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-notifications Notifications team label Jan 30, 2025
@matteoscurati matteoscurati changed the title fix: 🐛 fix insufficient funds displays incorrect native token (#2… fix: insufficient funds displays incorrect native token (#29828) Jan 30, 2025
@matteoscurati matteoscurati marked this pull request as ready for review January 30, 2025 14:55
@matteoscurati matteoscurati requested a review from a team as a code owner January 30, 2025 14:55
@metamaskbot
Copy link
Collaborator

Builds ready [f3d1168]
Page Load Metrics (1812 ± 74 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15472136181314670
domContentLoaded14992101178614469
load15072183181215574
domInteractive24182633617
backgroundConnect6100262512
firstReactRender1674392412
getState55015136
initialActions00000
loadScripts10391658132013766
setupStore65416178
uiStartup17662456209718790

@dbrans dbrans merged commit 539f6e0 into Version-v12.11.0 Jan 30, 2025
77 of 78 checks passed
@dbrans dbrans deleted the cherry-pick-v12.11-33ffbc59ef15116ddddbbfb8df6f30430fe48b82 branch January 30, 2025 16:44
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-notifications Notifications team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Send Alert - Insufficient funds displays incorrect native token as copy text and button text
4 participants