Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: centering on Snap radio buttons #29850

Merged
merged 1 commit into from
Jan 22, 2025
Merged

fix: centering on Snap radio buttons #29850

merged 1 commit into from
Jan 22, 2025

Conversation

hmalik88
Copy link
Contributor

@hmalik88 hmalik88 commented Jan 22, 2025

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions:

  1. What is the reason for the change? Radio buttons were not aligned with their labels in the snap component.
  2. What is the improvement/solution? Strip radio button of margin.

Related issues

Fixes: #29725

Manual testing steps

  1. Build this branch
  2. Go to https://metamask.github.io/snaps/test-snaps/2.18.0/
  3. Trigger the custom ui interactive snap dialog
  4. Observe the changes below.

Screenshots/Recordings

Before

See issue

After

Screenshot 2025-01-22 at 9 47 19 AM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-snaps-platform Snaps Platform team label Jan 22, 2025
@hmalik88 hmalik88 marked this pull request as ready for review January 22, 2025 14:57
@hmalik88 hmalik88 requested a review from a team as a code owner January 22, 2025 14:57
@FrederikBolding FrederikBolding added this pull request to the merge queue Jan 22, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [eb5617a]
Page Load Metrics (1674 ± 97 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14372196167619895
domContentLoaded14302137165019292
load14382204167420297
domInteractive248444199
backgroundConnect56920189
firstReactRender1695432713
getState472222210
initialActions01000
loadScripts9771604120517182
setupStore610711
uiStartup164823961908218104
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 19 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 22, 2025
@hmalik88 hmalik88 added this pull request to the merge queue Jan 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 22, 2025
@hmalik88 hmalik88 added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit ed2fb49 Jan 22, 2025
99 checks passed
@hmalik88 hmalik88 deleted the hm/fix-radio-buttons branch January 22, 2025 17:35
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2025
@metamaskbot metamaskbot added the release-12.12.0 Issue or pull request that will be included in release 12.12.0 label Jan 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.12.0 Issue or pull request that will be included in release 12.12.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Radio button text is misaligned
4 participants