Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: overflow of title/description in Snap Card component #29838

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

hmalik88
Copy link
Contributor

@hmalik88 hmalik88 commented Jan 21, 2025

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions:

  1. What is the reason for the change? Text overflow was not properly working for the title & description section of the Card snap component.
  2. What is the improvement/solution? Add a constraint to the parent container.

Related issues

Fixes: MetaMask/snaps#2815

Manual testing steps

  1. Build the extension
  2. Trigger a snap dialog with the example code in the issue
  3. Observe the below changes.

Screenshots/Recordings

Before

See issue link

After

Screenshot 2025-01-21 at 6 49 00 PM Screenshot 2025-01-21 at 6 48 00 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-snaps-platform Snaps Platform team label Jan 21, 2025
@hmalik88 hmalik88 marked this pull request as ready for review January 21, 2025 23:56
@hmalik88 hmalik88 requested a review from a team as a code owner January 21, 2025 23:56
@FrederikBolding FrederikBolding added this pull request to the merge queue Jan 22, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [134bdfa]
Page Load Metrics (1553 ± 66 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint13521800155513464
domContentLoaded13451788152213264
load13511796155313866
domInteractive218437168
backgroundConnect577282210
firstReactRender1597393115
getState5100202412
initialActions01000
loadScripts9731352113111354
setupStore580162211
uiStartup158225181900282135
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 26 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Merged via the queue into main with commit feb89fa Jan 22, 2025
103 checks passed
@FrederikBolding FrederikBolding deleted the hm/fix-card-overflow branch January 22, 2025 10:07
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2025
@metamaskbot metamaskbot added the release-12.12.0 Issue or pull request that will be included in release 12.12.0 label Jan 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.12.0 Issue or pull request that will be included in release 12.12.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Card title and description overflow
5 participants