-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: hide network picker back button when network is unselected #29711
Open
micaelae
wants to merge
2
commits into
main
Choose a base branch
from
mms1852-rm-network-picker-back-button
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds ready [d1b7579]
Page Load Metrics (1513 ± 44 ms)
Bundle size diffs
|
micaelae
force-pushed
the
mms1852-rm-network-picker-back-button
branch
from
January 16, 2025 23:38
d1b7579
to
a4e168e
Compare
Builds ready [a4e168e]
Page Load Metrics (1844 ± 157 ms)
Bundle size diffs
|
micaelae
force-pushed
the
mms1852-rm-network-picker-back-button
branch
from
January 21, 2025 20:23
a4e168e
to
76a5638
Compare
Builds ready [76a5638]
Page Load Metrics (1627 ± 30 ms)
Bundle size diffs
|
vinnyhoward
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This hides the network picker's back button when there's no selected network. Currently this causes the dest network picker to navigate to the src asset picker
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MMS-1852
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2025-01-21.at.12.26.52.PM.mov
After
Screen.Recording.2025-01-21.at.12.27.33.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist