feat: Add gasLimitNoBuffer to transactionMeta
#5113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
OGPoyraz
changed the title
estimatedGas to transactionMetagasLimitNoBuffer to transactionMeta
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
matthewwalsh0
requested changes
Jan 8, 2025
| @@ -170,7 +171,7 @@ async function getGas( | |||
| bufferMultiplier, | |||
| ); | |||
|
|
|||
| return [bufferedGas, simulationFails]; | |||
| return [bufferedGas, simulationFails, estimatedGas]; | |||
There was a problem hiding this comment.
Currently this is only being persisted if we actually do an eth_estimateGas but is it simpler to always save a value so the UI can always use it directly even if fixed or provided by the dApp?
| @@ -184,6 +184,11 @@ type TransactionMetaBase = { | |||
| /** Whether the gas fee estimates have been checked at least once. */ | |||
| gasFeeEstimatesLoaded?: boolean; | |||
|
|
|||
| /** | |||
| * The estimated gas for the transaction without buffer. | |||
There was a problem hiding this comment.
Suggested change
| * The estimated gas for the transaction without buffer. | |
| * The estimated gas for the transaction without any buffer applied. |
| ### Added | ||
|
|
||
| - Add `gasLimitNoBuffer` property to `TransactionMeta` type ([#5113](https://github.com/MetaMask/core/pull/5113)) | ||
| - `gasLimitNoBuffer` is the estimated gas (via `eth_estimateGas`) for the transaction without buffer. |
There was a problem hiding this comment.
Suggested change
| - `gasLimitNoBuffer` is the estimated gas (via `eth_estimateGas`) for the transaction without buffer. | |
| - `gasLimitNoBuffer` is the estimated gas for the transaction without any buffer applied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR aims to add
gasLimitNoBuffertotransactionMetato show minimum value while calculating network fee.References
Changelog
@metamask/transaction-controllergasLimitNoBuffertotransactionMetagasLimitNoBufferis the estimated gas (viaeth_estimateGas) for the transaction without buffer.Checklist