feat: add a customProvider option to the sdk JwtBearerAuth class
#5105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieuartu
added
the
team-identity
mathieuartu
changed the title
customProvider option to the sdk JwtBearerAuth class
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Prithpal-Sooriya
approved these changes
Jan 7, 2025
| @@ -44,6 +46,11 @@ export class JwtBearerAuth implements SIWEInterface, SRPInterface { | |||
| throw new UnsupportedAuthTypeError('unsupported auth type'); | |||
| } | |||
|
|
|||
| setCustomProvider(provider: Eip1193Provider) { | |||
| this.#assertSRP(this.#type, this.#sdk); | |||
There was a problem hiding this comment.
Perfect! Yeah we only need this for the SRP flow for now 🙂
| @@ -143,6 +143,28 @@ describe('Authentication - constructor()', () => { | |||
| ); | |||
| }).toThrow(UnsupportedAuthTypeError); | |||
| }); | |||
|
|
|||
| it('supports using a custom provider as a constructor option', async () => { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR adds the possibility to use a
customProviderfor theJwtBearerAuthclass.This is added both as a constructor option, and as a method to set the custom provider as a later point in time, using the
setCustomProvidermethod.References
Changelog
@metamask/profile-sync-controllercustomProvideroption for the sdkJwtBearerAuthclassChecklist