This repository has been archived by the owner on Sep 6, 2024. It is now read-only.
use MessageWrapper to sync acknowledge and timeout extender #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 10, 2024 14:38
OOlsen
suggested changes
Jun 12, 2024
| String.class), e); | ||
| throw new RuntimeException(e); | ||
| if (e.getCause() instanceof AlreadyAcknowledgedException) { | ||
| return; |
There was a problem hiding this comment.
Why introducing the new exception if we just ignore it.
There was a problem hiding this comment.
ok, removed with adda920
| @Getter | ||
| private final Message<I> message; | ||
|
|
||
| private final AtomicBoolean acknowledged = new AtomicBoolean(false); |
There was a problem hiding this comment.
What is the advantage of heaving an atomic boolean instead of a native boolean? The manipulating methods are already synchronized.
There was a problem hiding this comment.
replaced with boolean d1b1b9b
added 2 commits
June 13, 2024 08:36
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sync acknowledge and timeout extender: if the message is already acknowledged (deleted) then timeout extender will fail if this happens in the same millisecond