Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fir_async2_next]: kernel-uboot.bbclass: get rid of compression for arm64 kernel #1454

Open
wants to merge 1 commit into
base: dunfell
Choose a base branch
from

Conversation

ahsanhussain
Copy link
Contributor

Maintain a local copy of kernel-uboot.bbclass which overrides the
behavior from the upstream class and removes kernel compression from
arm64 kernel image. This saves up to 1s from slow targets at bootup

JIRA ID: SB-17289

Signed-off-by: Ahsan Hussain [email protected]

Maintain a local copy of kernel-uboot.bbclass which overrides the
behavior from the upstream class and removes kernel compression from
arm64 kernel image. This saves up to 1s from slow targets at bootup

JIRA ID: SB-17289

Signed-off-by: Ahsan Hussain <[email protected]>
@ahsanhussain ahsanhussain requested a review from abelal January 17, 2022 13:45
@ahsanhussain ahsanhussain changed the title kernel-uboot.bbclass: get rid of compression for arm64 kernel [fir_async2_next]: kernel-uboot.bbclass: get rid of compression for arm64 kernel Jan 17, 2022
@ahsanhussain
Copy link
Contributor Author

No compression means no extra time decompressing the kernel image

switch to partitions #0, OK
mmc0 is current device

MMC read: dev # 0, block # 8192, count 16 ... 16 blocks read: OK
55478480 bytes read in 3640 ms (14.5 MiB/s)
## Loading kernel from FIT Image at 0c880000 ...
   Using 'conf-system-top.dtb' configuration
   Trying 'kernel-1' kernel subimage
     Description:  Linux kernel
     Created:      2022-01-11  11:49:04 UTC
     Type:         Kernel Image
     Compression:  uncompressed
     Data Start:   0x0c880114
     Data Size:    46184960 Bytes = 44 MiB
     Architecture: AArch64
     OS:           Linux
     Load Address: 0x00000000
     Entry Point:  0x00000000
     Hash algo:    sha256
     Hash value:   6684d4ccf0552a25fd6ac78b8d5d5836ccd776afaffbd49f61427219dab17ac5
   Verifying Hash Integrity ... sha256+ OK
## Loading ramdisk from FIT Image at 0c880000 ...
   Using 'conf-system-top.dtb' configuration
   Trying 'ramdisk-1' ramdisk subimage
     Description:  mel-initramfs-image
     Created:      2022-01-11  11:49:04 UTC
     Type:         RAMDisk Image
     Compression:  uncompressed
     Data Start:   0x0f4995a0
     Data Size:    9235877 Bytes = 8.8 MiB
     Architecture: AArch64
     OS:           Linux
     Load Address: 0x06400000
     Entry Point:  unavailable
     Hash algo:    sha256
     Hash value:   8567d97a0f7691e8d55d875e80a6c6077bff75bb07d322d4933d4859f16ed602
   Verifying Hash Integrity ... sha256+ OK
   Loading ramdisk from 0x0f4995a0 to 0x06400000
## Loading fdt from FIT Image at 0c880000 ...
   Using 'conf-system-top.dtb' configuration
   Trying 'fdt-system-top.dtb' fdt subimage
     Description:  Flattened Device Tree blob
     Created:      2022-01-11  11:49:04 UTC
     Type:         Flat Device Tree
     Compression:  uncompressed
     Data Start:   0x0f48bc24
     Data Size:    55455 Bytes = 54.2 KiB
     Architecture: AArch64
     Load Address: 0x06200000
     Hash algo:    sha256
     Hash value:   830268b8e9a237c3cfc44196ca5af6fc6a4ddf9fe3b3b737f157ca3f48b2afcf
   Verifying Hash Integrity ... sha256+ OK
   Loading fdt from 0x0f48bc24 to 0x06200000
   Booting using the fdt blob at 0x6200000
   Loading Kernel Image
   Using Device Tree in place at 0000000006200000, end 000000000621089e

Starting kernel ...

@abelal
Copy link
Contributor

abelal commented Jan 19, 2022

Such a change might be worthy of upstreaming if we do it a bit differently using a variable i.e. the user should be able to select whether he needs a compressed kernel image or not. Also, is there a possibility for us to be using the first two if/else clauses to achieve the same?
Even with the answers to above the change would make most sense in staging.
@ahsanhussain thoughts?

@kergoth
Copy link
Member

kergoth commented May 21, 2022

Such a change might be worthy of upstreaming if we do it a bit differently using a variable i.e. the user should be able to select whether he needs a compressed kernel image or not. Also, is there a possibility for us to be using the first two if/else clauses to achieve the same?
Even with the answers to above the change would make most sense in staging.
@ahsanhussain thoughts?

For what it's worth, I agree, making this something the user can easily control would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants