Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fixes and Reorganization #4

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
/.idea/workspace.xml
/.idea/navEditor.xml
/.idea/assetWizardSettings.xml
/.idea
.DS_Store
/build
/captures
Expand Down
3 changes: 0 additions & 3 deletions .idea/.gitignore

This file was deleted.

1 change: 0 additions & 1 deletion .idea/.name

This file was deleted.

6 changes: 0 additions & 6 deletions .idea/compiler.xml

This file was deleted.

20 changes: 0 additions & 20 deletions .idea/gradle.xml

This file was deleted.

9 changes: 0 additions & 9 deletions .idea/misc.xml

This file was deleted.

11 changes: 6 additions & 5 deletions app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ android {
compileSdk 32

defaultConfig {
applicationId "com.example.ribs_demo_android"
applicationId "com.solacestudios.ribs_demo_android"
minSdk 23
targetSdk 32
versionCode 1
Expand Down Expand Up @@ -61,20 +61,21 @@ dependencies {
def retrofit_version = "2.9.0"
implementation "com.squareup.retrofit2:retrofit:$retrofit_version"
implementation "com.squareup.retrofit2:converter-gson:$retrofit_version"
implementation "com.squareup.retrofit2:adapter-rxjava3:$retrofit_version"

implementation 'com.jakewharton.rxbinding4:rxbinding-core:4.0.0'

def glide_version = "4.11.0"
implementation "com.github.bumptech.glide:glide:$glide_version"
kapt "com.github.bumptech.glide:compiler:$glide_version"

implementation 'com.jakewharton.retrofit:retrofit2-rxjava2-adapter:1.0.0'
implementation 'io.reactivex.rxjava2:rxandroid:2.1.0'
implementation 'io.reactivex.rxjava2:rxjava:2.2.4'

testImplementation 'junit:junit:4.12'
testImplementation "org.mockito:mockito-core:3.10.0"
testImplementation "com.nhaarman.mockitokotlin2:mockito-kotlin:2.2.0"
testImplementation "com.google.truth:truth:0.43"
testImplementation "com.google.testing.compile:compile-testing:0.17"
//testImplementation "org.mockito:mockito-all:1.10.19"
testImplementation 'org.mockito:mockito-inline:2.13.0'

implementation 'com.squareup.okhttp3:logging-interceptor:4.2.1'
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.example.ribs_demo_android
package com.solacestudios.ribs_demo_android

import androidx.test.platform.app.InstrumentationRegistry
import androidx.test.ext.junit.runners.AndroidJUnit4
Expand All @@ -19,6 +19,6 @@ class ExampleInstrumentedTest {
fun useAppContext() {
// Context of the app under test.
val appContext = InstrumentationRegistry.getInstrumentation().targetContext
assertEquals("com.example.ribs_demo_android", appContext.packageName)
assertEquals("com.solacestudios.ribs_demo_android", appContext.packageName)
}
}
6 changes: 3 additions & 3 deletions app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.example.ribs_demo_android">
package="com.solacestudios.ribs_demo_android">

<uses-permission android:name="android.permission.INTERNET"/>

<application
android:name=".App"
android:name="com.solacestudios.ribs_demo_android.App"
android:allowBackup="true"
android:icon="@mipmap/ic_launcher"
android:label="@string/app_name"
android:roundIcon="@mipmap/ic_launcher_round"
android:supportsRtl="true"
android:theme="@style/Theme.RibsDemoAndroid">
<activity
android:name=".ribs.MainActivity"
android:name="com.solacestudios.ribs_demo_android.ribs.MainActivity"
android:exported="true"
android:screenOrientation="portrait">
<intent-filter>
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading