add servo support to MAG_MOUNTED_PROBE #27551
Open
+35
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should have looked here first, just spent the afternoon implementing this myself. is there any chance of this branch been updated to latest, and also would it help get this one through if I helped test it out. |
ellensp
force-pushed
the
add-servo-support-to-magnetic-probe
branch
from
7d519a6 to
4a2f753
Compare
|
@gjdodd updated to current bugfix 2.1.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
User built machine with a MAG_MOUNTED_PROBE on a servo arm, a non supported configuration.
I added basic support for it.
Requirements
MAG_MOUNTED_PROBE
NUM_SERVOS
Z_SAFE_HOMING (a requirement)
new
MAG_MOUNTED_PROBE_SERVO_NR
MAG_MOUNTED_PROBE_SERVO_ANGLES
Benefits
A MAG_MOUNTED_PROBE on a servo arm has a chance of working.
User requesting this has provided videos that it work as intended
IMG_7736.mov