resolve limpmc issue in Pypi. Relates to https://github.com/jingnansh…

…i/pmc#2
MIT-SPARK · Jan 28, 2025 · 1c45beb · 1c45beb
1 parent e80b266
commit 1c45beb
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -2,7 +2,7 @@ set(CMAKE_CXX_STANDARD 17)
 set(CMAKE_CXX_STANDARD_REQUIRED ON)
 cmake_minimum_required(VERSION 3.18)
 project(robin
-        VERSION 1.2.1
+        VERSION 1.2.2
         DESCRIPTION "Robust outlier rejection based on measurement compatibility graphs"
         LANGUAGES CXX
         )

diff --git a/python/CMakeLists.txt b/python/CMakeLists.txt
@@ -10,6 +10,12 @@ set(CMAKE_POSITION_INDEPENDENT_CODE ON)
 set(CMAKE_CXX_STANDARD 17)
 set(CMAKE_CXX_STANDARD_REQUIRED ON)
 
+# NOTE (hlim): To generate `libpmc.a` instead of `libpmc.so`.
+# On a local computer, either `libpmc.a` or `libpmc.so` is fine,
+# but for PyPI, it should be `libpmc.a` to make it more independent of the environment.
+# More details can be found here: ttps://github.com/jingnanshi/pmc/pull/2
+option(PMC_BUILD_SHARED "Build PMC as a shared library" OFF)
+
 find_package(Python COMPONENTS Interpreter Development.Module REQUIRED)
 find_package(pybind11 CONFIG REQUIRED)
 

diff --git a/python/pyproject.toml b/python/pyproject.toml
@@ -4,7 +4,7 @@ build-backend = "scikit_build_core.build"
 
 [project]
 name = "spark_robin"
-version = "1.2.1"
+version = "1.2.2"
 requires-python = ">=3.8"
 description ='Python binding for Robin'
 authors = [