Skip to content

Commit

Permalink
refactor(renter): remove updateNodeLastUsed
Browse files Browse the repository at this point in the history
  • Loading branch information
pcfreak30 committed Dec 31, 2024
1 parent 1aa12d9 commit 545adbf
Showing 1 changed file with 0 additions and 40 deletions.
40 changes: 0 additions & 40 deletions service/internal/renter/client_manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -125,46 +125,6 @@ func (cm *ClientManager) updateNode(node NodeInfo) {
}
cm.nodes[node.Type] = append(cm.nodes[node.Type], node)
}
func (cm *ClientManager) updateNodeLastUsed(node *NodeInfo) {
if !cm.ctx.Config().Config().Core.ClusterEnabled() {
return
}

etcdMgr, err := cm.ctx.Config().Config().Core.Clustered.Etcd.GetManager(cm.logger.Logger)
if err != nil {
cm.logger.Error("failed to get etcd manager for updating node last used time", zap.Error(err))
return
}

client := etcdMgr.Client()

ctx, cancel := context.WithTimeout(context.Background(), 1*time.Second)
defer cancel()

nodeKey := fmt.Sprintf("%s/%s", cm.etcdKey, node.URL)
data, err := json.Marshal(node)
if err != nil {
cm.logger.Error("failed to marshal node info", zap.Error(err))
return
}

// Just use a short lease - we only need it for the update
lease, err := client.Grant(ctx, 1) // 1 second lease
if err != nil {
cm.logger.Error("failed to create lease", zap.Error(err))
return
}

_, err = client.Put(ctx, nodeKey, string(data), clientv3.WithLease(lease.ID))
if err != nil {
cm.logger.Error("failed to update node last used time in etcd", zap.Error(err))
// Revoke the lease to clean up
if _, revokeErr := client.Revoke(ctx, lease.ID); revokeErr != nil {
cm.logger.Error("failed to revoke lease after PUT failure", zap.Error(revokeErr))
}
return
}
}

func (cm *ClientManager) removeNode(node NodeInfo) {
nodes := cm.nodes[node.Type]
Expand Down

0 comments on commit 545adbf

Please sign in to comment.