Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update lock file and set engine to use pnpm v10 #536

Merged
merged 7 commits into from
Mar 1, 2025
Merged

chore: update lock file and set engine to use pnpm v10 #536

merged 7 commits into from
Mar 1, 2025
+23 −19

Conversation

doprz
Copy link
Collaborator

@doprz doprz commented Feb 28, 2025 •
edited
Loading

  • Set engine to use pnpm v10.x.x
  • Set engineStrict to true
  • Update pnpm-lock.yaml file
  • Update GitHub Actions to use pnpm v10 and pnpm/action-setup@v4
  • Update Dockerfile pnpm version

This change is Reviewable

@doprz doprz added dependencies Pull requests that update a dependency file blocked Do not merge (yet) build ci/cd labels Feb 28, 2025
@doprz doprz self-assigned this Feb 28, 2025
@doprz doprz marked this pull request as ready for review February 28, 2025 19:15
@doprz doprz changed the title chore: update lock file and set engine to use pnpm v10.5.2 chore: update lock file and set engine to use pnpm v10 Feb 28, 2025
Samathingamajig
Samathingamajig approved these changes Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@Samathingamajig Samathingamajig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes look good, but I cannot test them locally right now as I'm away from a computer. I advise having someone else test it before merging.

@Samathingamajig Samathingamajig self-requested a review March 1, 2025 04:18
@doprz doprz removed the blocked Do not merge (yet) label Mar 1, 2025
Samathingamajig
Samathingamajig approved these changes Mar 1, 2025
View reviewed changes
Copy link
Collaborator

@Samathingamajig Samathingamajig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doprz doprz merged commit 56a82ba into main Mar 1, 2025
12 checks passed
@doprz doprz deleted the chore/pnpm-v10 branch March 1, 2025 04:54
@doprz doprz added this to the v2.1.1 milestone Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Samathingamajig Samathingamajig Samathingamajig approved these changes

@Razboy20 Razboy20 Awaiting requested review from Razboy20

Assignees

@doprz doprz

Labels
build ci/cd dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
v2.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@doprz @Samathingamajig