fix: ics calendar export dates #535
Open
+285
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
doprz
requested changes
Mar 1, 2025
| '2028-07-04', // Independence Day holiday | ||
| ], | ||
| }, | ||
| } as const satisfies Partial<Record<SemesterIdentifier, AcademicCalendarSemester>>; |
Comment on lines
+1
to
+7
| type Digit = 0 | 1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9; | ||
| type Year = `20${Digit}${Digit}`; | ||
| type Month = `0${Exclude<Digit, 0>}` | `1${'0' | '1' | '2'}`; | ||
| type Day = `0${Exclude<Digit, 0>}` | `${1 | 2}${Digit}` | '30' | '31'; | ||
| type DateStr = `${Year}-${Month}-${Day}`; | ||
| type SemesterDigit = 2 | 6 | 9; | ||
| type SemesterIdentifier = `20${Digit}${Digit}${SemesterDigit}`; |
There was a problem hiding this comment.
Good use of Template Literal Types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now will export classes based on the academic calendar. Allows for skipping holidays and multi-day breaks. Accounts for semesters by using the semester info on the course itself, so it's legal to have a schedule with multiple semesters (though, that should be prevented in general, but that will be a separate PR).
Drawbacks: Doesn't support winter terms or any of the various summer terms, except it interprets all summer courses as full-term summer courses.
This change is