feat(ui): made top day labels sticky #486
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razboy20
added
feature
UI/UX-figma
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP for #357, would appreciate any help thanks!
Currently I have it such that the top bar with the day labels is sticky when the window height is small enough, but I have two main problems:
UI: I'm not really sure how to change the UI to allow for the sticky header, as the first time, 8 AM, can no longer be on the first horizontal line with the day labels. The Google calendar example resolves this by putting a gmt-5 on the line and the time below it, so I have something similar (image below):
Padding issue: Currently the padding is good when the scroll bar appears, but if the window is fullscreened (no scroll) then the padding for the days and the times is messed up. Image also provided below
Units: I had to put a decent amount of "arbitrary" paddings to actually line up the two sections, i.e. pr-7.5 for the top bar. Just wanted some feedback on some of the unit choices, whether they align with the figma/design principles, etc.
Before:
After (note the 8 AM line change):
Padding issue image when scrollbar is not present (fullscreen):
This change is