feat(ui): Accommodate early morning, late night, and Saturday classes (Resolves #399) #438
+97
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsaDavRod
requested changes
Nov 20, 2024
There was a problem hiding this comment.
This PR has some broken results upon opening calendar even while no late, early, or Saturday courses exist, and when they do exist. The height of y-axis hours are also inconsistent sometimes or the y-axis ticks do not align with the grid (this appears on your example screenshots).
Please resolve these issues and I can continue reviewing.
doprz
requested changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #399
Issue:
The calendar grid does not accommodate for early morning, late night, and Saturday courses, instead dumping them in the Async/Other category in the bottom bar.
Resolving the Issue:
I have redirected early morning, late night, and Saturday courses to the main calendar grid instead of the bottom bar.
I have made the calendar grid flexible: it grows larger to allow for early morning, late night, and Saturday courses, but shrinks back to standard size when the course is removed.
Early Morning Accommodation:
Late Night Accommodation:
Saturday Course Accommodation:
This change is