-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revision components related model.gans.pix2pix
#883
Draft
Jungwon-Lee
wants to merge
54
commits into
Lightning-Universe:master
Choose a base branch
from
Jungwon-Lee:revision_pix2pix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Revision components related model.gans.pix2pix
#883
Jungwon-Lee
wants to merge
54
commits into
Lightning-Universe:master
from
Jungwon-Lee:revision_pix2pix
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jungwon-Lee
force-pushed
the
revision_pix2pix
branch
3 times, most recently
from
September 18, 2022 04:26
e11ca2d
to
c2d9426
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Jungwon-Lee
force-pushed
the
revision_pix2pix
branch
from
September 18, 2022 04:34
48a41d6
to
cc120fa
Compare
for more information, see https://pre-commit.ci
Jungwon-Lee
requested review from
Borda,
otaj,
akihironitta,
ethanwharris and
awaelchli
as code owners
September 18, 2022 05:05
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
auto-merge was automatically disabled
June 16, 2023 18:18
Pull request was converted to draft
@Jungwon-Lee how is it going here? 🐰 |
otaj
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to be seeing this in my list of reviews anymore, so, I'm approving :D
How are you guys doing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #839
pl_bolts.models.gans.pix2pix.components.DownSampleConv
pl_bolts.models.gans.pix2pix.components.Generator
pl_bolts.models.gans.pix2pix.components.PatchGAN
pl_bolts.models.gans.pix2pix.components.UpSampleConv
pl_bolts.models.gans.pix2pix.pix2pix_module._weights_init
pl_bolts.models.gans.pix2pix.pix2pix_module.Pix2Pix
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃