Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/MIDAZ-501 #503

Merged
merged 45 commits into from
Feb 10, 2025
Merged

Feature/MIDAZ-501 #503

merged 45 commits into from
Feb 10, 2025

Conversation

MartinezAvellan
Copy link
Member

Midaz Pull Request Checklist

Pull Request Type

  • Auth
  • Infra
  • Ledger
  • Mdz
  • Transaction
  • Audit
  • Pipeline
  • Documentation

Checklist

Please check each item after it's completed.

  • I have tested these changes locally.
  • I have updated the documentation accordingly.
  • I have added necessary comments to the code, especially in complex areas.
  • I have ensured that my changes adhere to the project's coding standards.
  • I have checked for any potential security issues.
  • I have ensured that all tests pass.
  • I have updated the version appropriately (if applicable).
  • I have confirmed this code is ready for review.

Additional Notes

Obs: Please, always remember to target your PR to develop branch instead of main.

@MartinezAvellan MartinezAvellan added feature New feature don't merge Don't merge this PR refactor Refactor the code domain:portfolio Responsible for creating accounts domain:transactions Responsible for transactions and operations labels Feb 10, 2025
@MartinezAvellan MartinezAvellan self-assigned this Feb 10, 2025
@MartinezAvellan MartinezAvellan requested a review from a team as a code owner February 10, 2025 11:18
Copy link

what-the-diff bot commented Feb 10, 2025

PR Summary

  • Updated Server Communication Ports

    • Changed server port configurations for better coordination between services.
  • RabbitMQ Handling and Configuration Changes

    • Renamed RabbitMQ components, updated routing keys, and removed older configurations.
  • Deprecated gRPC-Ledger Functionality

    • Removed instances of gRPC communication for ledger management, signaling a shift towards different communication methods.
  • Removal of Deprecated HTTP Routes

    • Streamlined the HTTP routing for accounts, removing older pathways.
  • Structs and Repositories Simplification

    • Removed multiple fields from account-related structs and methods to streamline data structures.
  • Shifting from gRPC Server to HTTP Server Integration

    • Deleted whole files related to gRPC server and its associated methods, making HTTP the primary server integration.
  • Removal of Redundant Code

    • Discarded unused import statements and deprecated functionality.
  • Change in Account Handling Methods

    • Removed 'AllowSending' and 'AllowReceiving' fields, simplifying methods that involve accounts and transactions.
  • Update in Error and Balance Handling Methods

    • Introduced a better approach for handling errors and balance verifying during transactions.
  • Enhancement of Operation struct

    • Used *int64 instead of *float64 for various financial fields increasing accuracy in financial data handling in operations.
  • MockRepository Update

    • Improved mock repository with more descriptive parameter names and new functionality, better supporting testing.
  • RabbitMQ Consumer Updates and Code Cleanup

    • Enhancements in RabbitMQ consumers management and code cleaning by removing deprecated functionalities.
  • Changes Involving Balance Centric Approach

    • Refactored functions and tests to replace references from Account to Balance, reflecting a new balance-centric approach.
  • Database Migration and Transactions Updates

    • Handled the migration in database schema and incorporated changes in transactions related operations.
  • Removed gRPC Related Files and Adjusted Account Operations

    • Deleted protocol buffer definitions for gRPC service and related methods along with changing several account related functionalities.
  • Introduction of Balance Handling

    • Implemented Balance struct and related methods for managing balances in accounts.
  • Performance Improvements in System Resource Metrics

    • Utilized OpenTelemetry metric gauges and the gopsutil package for fetching CPU and memory usage directly improving performance.

@MartinezAvellan MartinezAvellan added infra Infrastructure improvements and additions env when have changes on environments labels Feb 10, 2025
@MartinezAvellan MartinezAvellan changed the title Feature/midaz 501 Feature/MIDAZ-501 Feb 10, 2025
@MartinezAvellan MartinezAvellan removed the don't merge Don't merge this PR label Feb 10, 2025
@MartinezAvellan MartinezAvellan merged commit 98e0aef into develop Feb 10, 2025
7 checks passed
Copy link

🎉 This PR is included in version 1.48.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:portfolio Responsible for creating accounts domain:transactions Responsible for transactions and operations env when have changes on environments feature New feature infra Infrastructure improvements and additions refactor Refactor the code released on @develop
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants