Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore #10 개발서버 cicd 구축 #10
Chore #10 개발서버 cicd 구축 #10
Changes from 12 commits
ab14134
e699933
7fe7152
a0b9e53
6a50103
f99aff3
36ecd22
cdc9713
ff6ef87
425ba82
2d3ee7d
8c28559
01d4f24
7b1f26b
62a32ce
3101797
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
도커 컨테이너를 가동할 때 도커 네트워크 설정을 안해도 괜찮나요??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저희가 현재는 컨테이너 끼리 통신을 요구하지않고 gachtaxi-dev.env를 통해 환경 변수를 주입하고있는 형태라서 별도의 추가적인 네트워크 설정이 필요가 없는걸로 판단하였습니다
도커가 기본적으로 기본 네트워크를 사용하여 컨테이너 간 통신을 지원하는 것으로 알고있어, 별도의 네트워크 설정 없이 배포에는 문제가 없을거같습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFTER_NAME과 BEFORE_NAME으로 새로운 컨테이너와 이전에 사용한 컨테이너를 분리한 게 정말 좋네요!
새로운 컨테이너 관련 쉘 스크립트를 수정할 때, 한 눈에 수정해야 하는 부분을 찾을 수 있어 좋네요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저도 아직 방법은 모릅니다만, 더이상 사용하지 않는 도커 이미지를 삭제하도록 해도 좋을 거 같아요.
CI/CD 구축 후 개발을 하면 항상 해당 서버에 도커 이미지가 잔뜩 쌓여있어 직접 일일이 지우기 번거롭더라고요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docker image prune-a -f 로 지울 수 있어요!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
배포 후 불필요한 이미지까지 정리하는 로직도 추가해서, 디스크 공간을 추가적으로 확보할 수 있도록 설정해놓겠습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
스프링 환경이 prod로 되어있네요!
dev로 돌리면 조을 것 같아용
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
해당 내용은 미처 확인하지 못헀던 부분이였습니다 !
수정 완료했습니다