Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/LIVE-15402: add gas fee drawer and fix fee fetching for swap-live-app #9228

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

kallen-ledger
Copy link
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2025 8:32am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2025 8:32am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2025 8:32am
web-tools ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2025 8:32am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Feb 13, 2025
@kallen-ledger kallen-ledger changed the title Feat/live 15402 Feat/LIVE-15402: add gas fee drawer and fix fee fetching Feb 14, 2025
@kallen-ledger kallen-ledger changed the title Feat/LIVE-15402: add gas fee drawer and fix fee fetching Feat/LIVE-15402: add gas fee drawer and fix fee fetching for swap-live-app Feb 14, 2025
@kallen-ledger kallen-ledger marked this pull request as ready for review February 14, 2025 09:05
@kallen-ledger kallen-ledger requested review from a team as code owners February 14, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants