Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: casper coin modularization #8878

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

feat: casper coin modularization #8878

wants to merge 15 commits into from

Conversation

Canestin
Copy link
Contributor

@Canestin Canestin commented Jan 13, 2025 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Casper Coin Modularization

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@Canestin Canestin requested a review from a team as a code owner January 13, 2025 08:48
@vercel Vercel
Copy link

vercel bot commented Jan 13, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 10:47am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2025 10:47am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2025 10:47am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 14, 2025 10:47am

@live-github-bot live-github-bot bot added the common Has changes in live-common label Jan 13, 2025
@Canestin Canestin force-pushed the LIVE-13677-casper-coin-module branch 2 times, most recently from 6c56528 to 9bcdecb Compare January 13, 2025 14:37
@Canestin Canestin force-pushed the LIVE-13677-casper-coin-module branch from 9bcdecb to 12b1818 Compare January 13, 2025 14:46
@Canestin Canestin force-pushed the LIVE-13677-casper-coin-module branch from 12b1818 to dbc2b71 Compare January 13, 2025 15:03
@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM labels Jan 13, 2025
qperrot
qperrot reviewed Jan 14, 2025
View reviewed changes
libs/coin-modules/coin-casper/package.json Show resolved Hide resolved
libs/coin-modules/coin-casper/package.json Outdated Show resolved Hide resolved
libs/coin-modules/coin-casper/src/common-logic/utils.ts Outdated Show resolved Hide resolved
libs/coin-modules/coin-casper/src/signer/getAddress.ts Outdated Show resolved Hide resolved
libs/coin-modules/coin-casper/src/signer/getAddress.ts Outdated Show resolved Hide resolved
libs/coin-modules/coin-casper/package.json Outdated Show resolved Hide resolved
.changeset/chatty-days-buy.md Outdated Show resolved Hide resolved
apps/ledger-live-mobile/src/families/casper/TransactionConfirmFields.tsx Outdated Show resolved Hide resolved
libs/coin-modules/coin-casper/package.json Outdated Show resolved Hide resolved
libs/coin-modules/coin-casper/src/bridge/broadcast.ts Show resolved Hide resolved
@Canestin Canestin force-pushed the LIVE-13677-casper-coin-module branch from fb8d5a9 to 66538a7 Compare January 15, 2025 12:30
@LedgerHQ LedgerHQ deleted a comment from github-actions bot Jan 15, 2025
@LedgerHQ LedgerHQ deleted a comment from github-actions bot Jan 16, 2025
@LedgerHQ LedgerHQ deleted a comment from github-actions bot Jan 16, 2025
@Canestin Canestin force-pushed the LIVE-13677-casper-coin-module branch from 41e3ce1 to bfca297 Compare January 16, 2025 13:57
@Canestin Canestin force-pushed the LIVE-13677-casper-coin-module branch from e70b7ac to a127e1d Compare January 21, 2025 09:22
@LedgerHQ LedgerHQ deleted a comment from github-actions bot Jan 21, 2025
@Canestin Canestin force-pushed the LIVE-13677-casper-coin-module branch from 7e2606e to 9753468 Compare February 11, 2025 09:17
@live-github-bot live-github-bot bot removed the screenshots Screenshots have been updated label Feb 11, 2025
@Canestin Canestin force-pushed the LIVE-13677-casper-coin-module branch from f39260e to 44bd781 Compare February 12, 2025 23:30
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
0.0% Coverage on New Code (required ≥ 80%)
5.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@Canestin Canestin force-pushed the LIVE-13677-casper-coin-module branch from 051f73e to be06612 Compare February 14, 2025 08:09
@Canestin Canestin requested a review from a team as a code owner February 14, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qperrot qperrot qperrot left review comments

@Wozacosta Wozacosta Wozacosta left review comments

@ComradeAERGO ComradeAERGO ComradeAERGO left review comments

@ypolishchuk-ledger ypolishchuk-ledger ypolishchuk-ledger left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Canestin Canestin

Labels
common Has changes in live-common desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Canestin @Wozacosta @qperrot @ComradeAERGO @ypolishchuk-ledger