Improvements in commands parsing support #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kingofpayne this needs to be rebased following the merge of #98 |
Translation from an ApduHeader to a custom command type can now return different status words, which are then automatically sent as reply to the host by the SDK. This allows to implement complex parsing logic which may return appropriate error status words depending on which APDU header fields are invalid (invalid class, invalid instruction, bad P1 or P2, etc.). Added a check to reject automatically too short APDUs, so SDK users don't have to do this check in the app code.
Data field length is now checked in decode_event so SDK users do not need to perform this verification in the app.
kingofpayne
force-pushed
the
better-commands-parsing
branch
from
d9cfe22 to
d7e20b2
Compare
|
Rebased. |
yhql
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translation from an
ApduHeaderto a custom command type can now return different status words, which are then automatically sent as reply to the host by the SDK.This allows to implement complex parsing logic which may return appropriate error status words depending on which APDU header fields are invalid (invalid class, invalid instruction, bad P1 or P2, etc.).
Added a check to reject automatically too short APDUs, so SDK users don't have to do this check in the app code.