Fix pin lock issue during io reset + Fix S+ and X SRAM size #239
+19
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yogh333
requested review from
agrojean-ledger,
fbeutin-ledger and
tdejoigny-ledger
yogh333
changed the title
|
|
||
| // If the app has just been booted from the UX, multiple os_ux calls may be necessary | ||
| // to ensure UX layer has take the BOLOS_UX_IO_RESET instruction into account. | ||
| for (uint8_t i = 0; i < 2; i++) { |
There was a problem hiding this comment.
Good question, just a copy/paste from the C SDK: https://github.com/LedgerHQ/ledger-secure-sdk/blob/55afb4121b299635fae561239e44d2d5a60e3780/src/os_io_seproxyhal.c#L428
yogh333
force-pushed
the
y333/avoid_unwanted_pin_lock_during_io_reset
branch
from
c2d4bc3 to
42efbd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix from https://ledgerhq.atlassian.net/browse/B2CA-1967