Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sysroot fallback #238

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Fix sysroot fallback #238

merged 2 commits into from
Feb 4, 2025

Conversation

apaillier-ledger
Copy link
Contributor

@apaillier-ledger apaillier-ledger commented Feb 4, 2025 •
edited
Loading

So it is aligned with the C SDK : LedgerHQ/ledger-secure-sdk#841

@apaillier-ledger apaillier-ledger marked this pull request as ready for review February 4, 2025 10:48
yogh333
yogh333 approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@yogh333 yogh333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apaillier-ledger apaillier-ledger merged commit 1b289c6 into master Feb 4, 2025
42 of 44 checks passed
@apaillier-ledger apaillier-ledger deleted the fix/apa/sysroot_fallback branch February 4, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yogh333 yogh333 yogh333 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apaillier-ledger @yogh333