-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/update nanosplus sdk #115
Conversation
yogh333
commented
Jan 10, 2024
- [ledger_secure_sdk_sys] Update C SDK for Nano S+ if cloned when building Rust SDK
- [cargo-ledger] retrieve C SDK from app-builder docker container
… if not already defined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tiny typo on "have" but it's alright :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about it, but I think you should bump the version of ledger-secure-sdk-sys used by ledger-device-sdk crate to use the last one?
To make sure that the sys crate doesn't get build twice with different versions?
Yes you are right |