Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/update nanosplus sdk #115

Merged
merged 9 commits into from
Jan 11, 2024
Merged

Feat/update nanosplus sdk #115

merged 9 commits into from
Jan 11, 2024

Conversation

yogh333
Copy link
Contributor

@yogh333 yogh333 commented Jan 10, 2024

  • [ledger_secure_sdk_sys] Update C SDK for Nano S+ if cloned when building Rust SDK
  • [cargo-ledger] retrieve C SDK from app-builder docker container

@yogh333 yogh333 marked this pull request as ready for review January 10, 2024 16:16
cargo-ledger/src/main.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@yhql yhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny typo on "have" but it's alright :D

Copy link
Contributor

@xchapron-ledger xchapron-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about it, but I think you should bump the version of ledger-secure-sdk-sys used by ledger-device-sdk crate to use the last one?
To make sure that the sys crate doesn't get build twice with different versions?

@yogh333
Copy link
Contributor Author

yogh333 commented Jan 11, 2024

Not sure about it, but I think you should bump the version of ledger-secure-sdk-sys used by ledger-device-sdk crate to use the last one?
To make sure that the sys crate doesn't get build twice with differen

Yes you are right

@yogh333 yogh333 merged commit 5343bc4 into master Jan 11, 2024
21 checks passed
@yogh333 yogh333 deleted the feat/update_nanosplus_sdk branch January 11, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants