Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust] Use cargo metadata to get binary name #61

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

yogh333
Copy link
Contributor

@yogh333 yogh333 commented Feb 13, 2024

No description provided.

@yogh333 yogh333 force-pushed the jca/update_reusable_build branch from 585e510 to a7365eb Compare February 13, 2024 14:27
@yogh333 yogh333 changed the title [Rust] Use bash commands to rename binary for Ragger tests [Rust] Use cargo metadata to get binary name Feb 13, 2024
Copy link
Contributor

@xchapron-ledger xchapron-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer a solution like this one: https://github.com/LedgerHQ/cargo-ledger/pull/33/files

@agrojean-ledger
Copy link
Contributor

I would prefer a solution like this one: https://github.com/LedgerHQ/cargo-ledger/pull/33/files

@xchapron-ledger we can still implement the standard tree in cargo ledger but we need a quick fix for CI issues seen by Obsidian

@yogh333 yogh333 merged commit ef44afb into master Feb 14, 2024
5 checks passed
@yogh333 yogh333 deleted the jca/update_reusable_build branch February 14, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants