Redo SPL send implementation following spec update #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbeutin-ledger
force-pushed
the
fbe/revamp_spl_send
branch
6 times, most recently
from
8378f4d to
9b36f57
Compare
|
C tests are broken because there is no mock feature |
fbeutin-ledger
force-pushed
the
fbe/revamp_spl_send
branch
5 times, most recently
from
bf9a872 to
26bbe8b
Compare
fbeutin-ledger
force-pushed
the
fbe/revamp_spl_send
branch
from
26bbe8b to
ba3d749
Compare
| trusted_name_info->struct_version = value; | ||
| return true; | ||
| static void trusted_info_reset(trusted_info_t *trusted_info) { | ||
| explicit_bzero(trusted_info, sizeof(trusted_info)); | ||
| } |
There was a problem hiding this comment.
Should be sizeof(*trusted_info)
| sig_ctx->input_sig_size)); | ||
| // Save the encoded address | ||
| memset(out_encoded_address, 0, BASE58_PUBKEY_LENGTH); | ||
| memcpy(out_encoded_address, in_encoded_address.ptr, in_encoded_address.size); |
There was a problem hiding this comment.
Behavior is undefined if memcpy src or dst is NULL even when size is 0. In practice not sure it can happens because messages are signed and thus cannot be manipulated by an attacker.
Still better not to call memcpy with a null pointer y adding a precondition or setting it to a pointer even if size is 0 during parsing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.