More flexible build script for Android support #594
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to be able to bind
tch
to PyTorch Mobile (libtorch
on Android). To this end, I made a few changes to the build script:libtorch
(ex.:LIBTORCH_LIB_aarch64-linux-android
) so that I can give a path to a differentlibtorch
for each architecture and OS.include
andlib
from theLIBTORCH_INCLUDE
andLIBTORCH_LIB
paths, so the user is now supposed to include these in the paths themselves. This is a breaking change, but it was necessary to make things work on Android, because the folders have different names there..so
file, so I added aLIBTORCH_LITE
file to tell the build script which one we are linking against.I also made some changes to the code, namely support for moving tensors to the Vulkan device. I was disappointed to find out that PyTorch support for Vulkan is pretty half-baked, but still.