Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linear view scrolls to selection when passed by prop #253

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

guzmanvig
Copy link
Collaborator

@guzmanvig guzmanvig commented Jan 3, 2024

Sets the central index initially to the prop selection.start, and then if the selection is updated, also updates the index.

One thing I didn't know was whether to update the central circular index as well. I'm not sure what the use for it, but let me know if I should do it too @jjti

solves #252

@guzmanvig guzmanvig requested a review from jjti January 3, 2024 20:35
Copy link
Collaborator

@jjti jjti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one caveat about just using start

src/SeqViewerContainer.tsx Outdated Show resolved Hide resolved
Co-authored-by: Joshua Timmons <[email protected]>
@guzmanvig guzmanvig merged commit a806197 into develop Jan 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants