LibWeb: Commit pull-into descriptors after filling from queue #2694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennethmyhra
changed the title
shannonbooth
suggested changes
Dec 1, 2024
Tests/LibWeb/Text/input/Streams/ReadableByteStream-byob-commit-pull-into-descriptor.html
Outdated
Show resolved
Hide resolved
kennethmyhra
force-pushed
the
commit-pull-into-descriptors-after-filling-from-queue
branch
from
b028857 to
6fe9f34
Compare
|
Thanks, Shannon! Updated the spec comments as suggested and pulled in the relevant WPT test. |
shannonbooth
approved these changes
Dec 2, 2024
These changes make sure that we postpone calls to ReadableByteStreamControllerCommitPullIntoDescriptor until after all pull-into descriptors have been filled up by ReadableByteStreamControllerProcessPullIntoDescriptorsUsingQueue. Also pulls in the WPT test which was created in relation to this spec change. The test verifies that a patched then() will see a null byobRequest.
kennethmyhra
force-pushed
the
commit-pull-into-descriptors-after-filling-from-queue
branch
from
6fe9f34 to
02088a7
Compare
kennethmyhra
deleted the
commit-pull-into-descriptors-after-filling-from-queue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns us with the latest streams specification changes to accommodate for the security advisor GHSA-p5g2-876g-95h9.
See relevant links:
GHSA-p5g2-876g-95h9
whatwg/streams#1326
Previously we would just crash on an assert in ReadableByteStreamControllerFillHeadPullIntoDescriptor which verifies that controller controller.raw_byob_request() should be null.
These changes make sure that we postpone calls to ReadableByteStreamControllerCommitPullIntoDescriptor until after all
pull-into descriptors have been filled up by ReadableByteStreamControllerProcessPullIntoDescriptorsUsingQueue.
The attached test verifies that a patched then() will see a null byobRequest.