LibWeb: Check presence of WWW-Authenticate header in fetch response
#1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcl3
reviewed
Aug 13, 2024
gmta
force-pushed
the
libweb-fetching-401-header-check
branch
from
84f0e44 to
be14aa8
Compare
Ty, fixed! |
If a HTTP 401 response we get does not contain a `WWW-Authenticate` header, we should not trigger the logic to ask the user for credentials and retry the request. This part is hinted at in a TODO / 'Needs testing' remark in the spec but needs to be fleshed out. Raised an upstream issue to do so: whatwg/fetch#1766 This fixes login forms triggering an infinite fetch loop when providing incorrect credentials. Co-Authored-By: Victor Tran <[email protected]>
gmta
force-pushed
the
libweb-fetching-401-header-check
branch
from
be14aa8 to
46f36e0
Compare
tcl3
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a HTTP 401 response we get does not contain a
WWW-Authenticateheader, we should not trigger the logic to ask the user for credentials and retry the request.This part is hinted at in a TODO / 'Needs testing' remark in the spec but needs to be fleshed out. Raised an upstream issue to do so:
whatwg/fetch#1766
This fixes login forms triggering an infinite fetch loop when providing incorrect credentials.
PR #357 has a similar change but went stale-ish since last month, so this supersedes it. @vicr123 I'll gladly mention you as co-author if you'd like!