PR49 fix

[HaiwangYu]

Thanks to @tomjunk and Andrew Olivier for spotting this bug! Details in #51

The fix is in two parts.

• minor bug: scale needs to be set to 1.0 for some cases. This PR fixes a bug when not setting it.
• main bug: The configurations needs to be updated together with the new CookedFrameSource as @tomjunk suggested. This is fixed in sweep change for new CookedFrameSource DUNE/dunereco#126
  • as suggested by @brettviren, a back-compat mode was added in d26b2da
• Next: need to check whether other non-DUNE experiments also used the CookedFrameSource, currently find none by searching the wire-cell-toolkit repo.

Some notes:
larwirecell-pr49.pdf

[FNALbuild]

A new Pull Request was created by @HaiwangYu (Haiwang Yu) for develop.

It involves the following packages:

larwirecell

@LArSoft/level-2-managers, @LArSoft/level-1-managers can you please review it and eventually sign? Thanks.

cms-bot commands are listed here

[FNALbuild]

The code-checks are being triggered in jenkins.

[FNALbuild]

-code-checks
Pull request failed code-formatting checks. Please ensure that cetmodules has been setup and execute the following command from the top-level directory of your repository:

format-code \
  larwirecell/Components/CookedFrameSource.cxx

Then commit the changes and push them to your PR branch.

[FNALbuild]

Pull request #53 was updated. @LArSoft/level-2-managers, @LArSoft/level-1-managers can you please check and sign again.

[FNALbuild]

The code-checks are being triggered in jenkins.

[FNALbuild]

+code-checks

[FNALbuild]

Pull request #53 was updated. @LArSoft/level-2-managers, @LArSoft/level-1-managers can you please check and sign again.

[FNALbuild]

The code-checks are being triggered in jenkins.

[FNALbuild]

+code-checks

[lgarren]

trigger build

[FNALbuild]

The tests are being triggered in jenkins.

[lgarren]

@tomjunk we'd like your signoff on this one

[FNALbuild]

+LArSoft tests OK on slf7 for c14:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:LArSoft/view_builds/index?offset=0&builds=lar_ci/24693&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=&builds=

[FNALbuild]

+LArSoft tests OK on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:LArSoft/view_builds/index?offset=0&builds=lar_ci/24692&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=&builds=

[FNALbuild]

-ICARUS tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:ICARUS/view_builds/index?offset=0&builds=icarus_ci/11251&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/24692&builds=

[FNALbuild]

-SBND tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:SBND/view_builds/index?offset=0&builds=sbnd_ci/15817&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/24692&builds=

[FNALbuild]

-DUNE tests warning on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:DUNE/view_builds/index?offset=0&builds=dune_ci/18620&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/24692&builds=

[FNALbuild]

-uBooNE tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:uBooNE/view_builds/index?offset=0&builds=uboone_ci/11692&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/24692&builds=

[tomjunk]

I tested this interactively (along with dunereco PR #126) and the product sizes look the same for the PDSP reco CI test with this fix and before PR #49. I'll take another look at the commits.

[tomjunk]

Approved

[FNALbuild]

This pull request is fully signed and it will be merged to develop and built in the next LArSoft release after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged.)

[lgarren]

approve