Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update project routes #55

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Update project routes #55

merged 1 commit into from
Nov 28, 2024

Conversation

juancwu
Copy link
Contributor

@juancwu juancwu commented Nov 27, 2024

Updated the project routes to match the /projects prefix pattern and also updated handlers depended on path param to get id. Some were using project_id which did not match the path param when defining the route.

@juancwu juancwu added the bug Something isn't working label Nov 27, 2024
@juancwu juancwu self-assigned this Nov 27, 2024
@juancwu juancwu linked an issue Nov 27, 2024 that may be closed by this pull request
Fix backend tests #52
Closed
@juancwu juancwu mentioned this pull request Nov 27, 2024
Merged
AmirAgassi
AmirAgassi approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@AmirAgassi AmirAgassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, improves consistency. lgtm

@juancwu juancwu merged commit dc6c716 into main Nov 28, 2024
4 checks passed
@juancwu juancwu deleted the fix/52/update-backend-tests branch November 28, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmirAgassi AmirAgassi AmirAgassi approved these changes

@aidantrabs aidantrabs Awaiting requested review from aidantrabs

Assignees

@juancwu juancwu

Labels
bug Something isn't working
Projects
Onboard by SPUR
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix backend tests
2 participants
@juancwu @AmirAgassi