Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed mismatched backend and frontend permissions #489

Merged
merged 1 commit into from
Feb 16, 2025
Merged

Fixed mismatched backend and frontend permissions #489

merged 1 commit into from
Feb 16, 2025

Conversation

AmirAgassi
Copy link
Member

Description

Aligned permission bit positions between the frontend and backend.

Linked Issues

Testing

lgtm

Checklist

Before opening this PR, make sure the PR:

  • Has an assignee or group of assignees.
  • Has a reviewer or a group of reviewers.
  • Is labelled properly.
  • Has the SPUR project assigned to it.
  • Has an assigned milestone.

Additionally, make sure that:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@AmirAgassi AmirAgassi added bug Something isn't working frontend Related to the frontend of the project backend Related to the backend of the project labels Feb 13, 2025
@AmirAgassi AmirAgassi self-assigned this Feb 13, 2025
@AmirAgassi AmirAgassi linked an issue Feb 13, 2025 that may be closed by this pull request
Fix backend and frontend permission names being mismatched #457
Closed
4 tasks
Copilot
Copilot AI reviewed Feb 13, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
@AmirAgassi AmirAgassi force-pushed the fix/457/align-fe-be-perms branch from e344868 to d3fe450 Compare February 13, 2025 23:11
juancwu
juancwu reviewed Feb 13, 2025
View reviewed changes
backend/internal/permissions/permissions.go

PermStartupOwner = PermSubmitProject | PermCommentOnProjects | PermManageDocuments | PermManageTeam
PermStartupOwner = PermSubmitProject | PermCommentOnProjects | PermManageDocuments |
PermManageTeam
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this in a new line? Weird formatting lol

@AmirAgassi AmirAgassi merged commit d70799c into main Feb 16, 2025
3 of 5 checks passed
@AmirAgassi AmirAgassi deleted the fix/457/align-fe-be-perms branch February 16, 2025 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@juancwu juancwu juancwu approved these changes

@aidantrabs aidantrabs Awaiting requested review from aidantrabs

Assignees

@AmirAgassi AmirAgassi

Labels
backend Related to the backend of the project bug Something isn't working frontend Related to the frontend of the project
Projects
Onboard by SPUR
Status: Done
Milestone
M2: Add ETHDenver preview features to...
Development

Successfully merging this pull request may close these issues.

Fix backend and frontend permission names being mismatched
2 participants
@AmirAgassi @juancwu