Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure navigation bar in project form pages are sticky #425

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

juancwu
Copy link
Contributor

@juancwu juancwu commented Feb 5, 2025

Description

This PR makes the navigation bar for all project form pages sticky.

Also made the "back to dashboard" link's clickable area bigger and hover effect.

Linked Issues

Checklist

Before opening this PR, make sure the PR:

  • Has an assignee or group of assignees.
  • Has a reviewer or a group of reviewers.
  • Is labelled properly.
  • Has the SPUR project assigned to it.
  • Has an assigned milestone.

Additionally, make sure that:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@juancwu juancwu added enhancement New feature or request frontend Related to the frontend of the project labels Feb 5, 2025
@juancwu juancwu added this to the Complete the project MVP milestone Feb 5, 2025
@juancwu juancwu self-assigned this Feb 5, 2025
@juancwu juancwu linked an issue Feb 5, 2025 that may be closed by this pull request
4 tasks
Copy link
Member

@aidantrabs aidantrabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@juancwu juancwu merged commit 670489f into main Feb 5, 2025
3 of 4 checks passed
@juancwu juancwu deleted the feat/424/ensure-navigation-in-forms-are-sticky branch February 5, 2025 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Related to the frontend of the project
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FE Feat] Ensure the form section navigation tabs are sticky
2 participants