Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix usage of undefined user role #355

Merged
merged 1 commit into from
Jan 29, 2025
Merged

fix usage of undefined user role #355

merged 1 commit into from
Jan 29, 2025

Conversation

juancwu
Copy link
Contributor

@juancwu juancwu commented Jan 29, 2025 •
edited
Loading

Description

fix usage of undefined user role
hot fix after the merge of #354

Checklist

Before opening this PR, make sure the PR:

  • Has an assignee or group of assignees.
  • Has a reviewer or a group of reviewers.
  • Is labelled properly.
  • Has the SPUR project assigned to it.
  • Has an assigned milestone.

Additionally, make sure that:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@juancwu
fix usage of undefined user role
7a251d5 
added permissions when verifying cookie
@juancwu juancwu added bug Something isn't working backend Related to the backend of the project labels Jan 29, 2025
@juancwu juancwu added this to the Complete the project MVP milestone Jan 29, 2025
@juancwu juancwu self-assigned this Jan 29, 2025
@juancwu juancwu marked this pull request as ready for review January 29, 2025 19:00
aidantrabs
aidantrabs approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@aidantrabs aidantrabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@juancwu juancwu merged commit 0828bd5 into main Jan 29, 2025
3 of 4 checks passed
@juancwu juancwu deleted the fix/0/backend-using-undefined-user-roles branch January 29, 2025 19:11
@SherRao SherRao removed this from the M1: Complete project MVP milestone Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aidantrabs aidantrabs aidantrabs approved these changes

@AmirAgassi AmirAgassi Awaiting requested review from AmirAgassi

Assignees

@juancwu juancwu

Labels
backend Related to the backend of the project bug Something isn't working
Projects
Onboard by SPUR
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juancwu @aidantrabs @SherRao